fix: declare loggers with the enclosing class, not another/super class#1387
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Merged
Conversation
Three loggers were created for the wrong category, so their records show up under an unrelated class: - EObjectDescriptions used getLogger(NameFunctions.class) (unrelated class) - DefaultCheckQuickfixProvider used its superclass DefaultQuickfixProvider - CustomClassAwareEcoreGenerator used its superclass EcoreGenerator Use the enclosing class literal in each, per the LogManager.getLogger convention. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three
LogManager.getLogger(...)declarations used the wrong class literal, so their log records appear under an unrelated category:EObjectDescriptionsNameFunctions.class(unrelated class)EObjectDescriptions.classDefaultCheckQuickfixProviderDefaultQuickfixProvider.class(superclass)DefaultCheckQuickfixProvider.classCustomClassAwareEcoreGeneratorEcoreGenerator.class(superclass)CustomClassAwareEcoreGenerator.classEach declares its own
LOGGERfield, so the category should be the enclosing class. Found by a repo-wide inconsistency sweep.🤖 Generated with Claude Code